Remember narrowed types from the constructor from deep PropertyFetches#4315
Merged
ondrejmirtes merged 4 commits intophpstan:2.1.xfrom Sep 10, 2025
Merged
Remember narrowed types from the constructor from deep PropertyFetches#4315ondrejmirtes merged 4 commits intophpstan:2.1.xfrom
ondrejmirtes merged 4 commits intophpstan:2.1.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types which get narrowed in __construct() on
readonlyproperties can be useful when analyzing other methods.improve support initially added with #3930 by allowing property-fetch-chains, when all involved properties are readonly.
preparational work for #4313 (comment)
commit1 extracts 1:1 a new method
commit2+3 adds support for property-fetch chains
commit4 re-use the new method for shouldInvalidateExpression()